third_party/WebKit/Source/core/inspector/InspectorHighlight.h - Issue 2108803006: Fix inspector overlay when use-zoom-for-dsf is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHighlight.h

Issue 2108803006: Fix inspector overlay when use-zoom-for-dsf is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: plumb through frameview instead Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.h ('K') | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHighlight.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHighlight.h b/third_party/WebKit/Source/core/inspector/InspectorHighlight.h

index d8e1ef862ae087126c1c58a36b33484746970331..e1b1bedbcabc959aca3e290720e4edbd543b7e2b 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHighlight.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorHighlight.h

@@ -46,7 +46,7 @@ class CORE_EXPORT InspectorHighlight {

STACK_ALLOCATED();

public:

InspectorHighlight(Node*, const InspectorHighlightConfig&, bool appendElementInfo);

- InspectorHighlight();

+ InspectorHighlight(float highlightScale);

dgozman 2016/07/07 00:30:09 style: explicit

Bret 2016/07/07 01:15:11 Done.

~InspectorHighlight();

static bool getBoxModel(Node*, std::unique_ptr<protocol::DOM::BoxModel>*);

@@ -67,6 +67,7 @@ private:

bool m_showRulers;

bool m_showExtensionLines;

bool m_displayAsMaterial;

+ float m_highlightScale;

dgozman 2016/07/07 00:30:10 Just m_scale. It's already a highlight object.

Bret 2016/07/07 01:15:11 Done. Changed in PathBuilder::appendPath and Shape

};

} // namespace blink