ios/chrome/BUILD.gn - Issue 2108783005: [ios] Implemented iOS analogue of SSLErrorHandler class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/BUILD.gn

Issue 2108783005: [ios] Implemented iOS analogue of SSLErrorHandler class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/BUILD.gn

diff --git a/ios/chrome/BUILD.gn b/ios/chrome/BUILD.gn

index c9f1bf664300f6f8738906a6fd8badb9b72d2833..de0e8420567f19fef4f52cbd390064c1e79851db 100644

--- a/ios/chrome/BUILD.gn

+++ b/ios/chrome/BUILD.gn

@@ -51,6 +51,10 @@ test("ios_chrome_unittests") {

"browser/snapshots/lru_cache_unittest.mm",

"browser/snapshots/snapshot_cache_unittest.mm",

"browser/snapshots/snapshots_util_unittest.mm",

+ # TODO(crbug.com/624450): Add this test back once gn build contains all

sdefresne 2016/06/30 12:01:17 Should work once https://codereview.chromium.org/2

Eugene But (OOO till 7-30) 2016/06/30 18:35:57 It does work now. Thank you for fixing this!

+ # needed resources.

+ # "browser/ssl/ios_ssl_error_handler_unittest.mm",

"browser/translate/translate_service_ios_unittest.cc",

"browser/ui/commands/set_up_for_testing_command_unittest.mm",

"browser/ui/context_menu/context_menu_coordinator_unittest.mm",

« no previous file with comments | « no previous file | ios/chrome/browser/BUILD.gn » ('j') | ios/chrome/browser/ssl/ios_ssl_error_handler.h » ('J')