Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2108723003: Promote NotificationBadge to stable. (Closed)

Created:
4 years, 5 months ago by Michael van Ouwerkerk
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Promote NotificationBadge to stable. Intent to ship: http://bit.ly/295ZVHZ BUG=591394 Committed: https://crrev.com/5b01b7dba7c0c0267fd535a20e479ea7eb3ccc40 Cr-Commit-Position: refs/heads/master@{#403258}

Patch Set 1 #

Patch Set 2 : Adjust expectations. #

Patch Set 3 : Rebase. #

Messages

Total messages: 29 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108723003/1
4 years, 5 months ago (2016-06-29 15:40:02 UTC) #2
Michael van Ouwerkerk
4 years, 5 months ago (2016-06-29 15:41:12 UTC) #5
Peter Beverloo
lgtm Please do fix the stable web-exposed layout tests when they come back as failures ...
4 years, 5 months ago (2016-06-29 16:15:14 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/254762) win_chromium_rel_ng on ...
4 years, 5 months ago (2016-06-29 17:04:00 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108723003/20001
4 years, 5 months ago (2016-06-30 12:44:19 UTC) #10
Michael van Ouwerkerk
Dimitri: please take a quick look as OWNER.
4 years, 5 months ago (2016-06-30 12:47:44 UTC) #12
Michael van Ouwerkerk
Dimitri, Rick, could one of you please take a quick look as OWNER?
4 years, 5 months ago (2016-06-30 12:51:39 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 13:58:48 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108723003/40001
4 years, 5 months ago (2016-06-30 16:39:01 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 17:53:28 UTC) #20
Rick Byers
LGTM
4 years, 5 months ago (2016-06-30 19:12:25 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108723003/40001
4 years, 5 months ago (2016-06-30 19:43:23 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 19:49:23 UTC) #26
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 19:49:28 UTC) #27
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:50:39 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5b01b7dba7c0c0267fd535a20e479ea7eb3ccc40
Cr-Commit-Position: refs/heads/master@{#403258}

Powered by Google App Engine
This is Rietveld 408576698