chromite: check response status code

scripts/common/cros_chromite.py

 #!/usr/bin/env python2.7
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This module wraps ChromeOS's Chromite configuration, providing retrieval
 methods and Infra-aware introspection.
 
 For any given ChromeOS build, Chromite may be pinned to a specific ChromeOS
@@ skipping 482 matching lines @@
 
     Raises:
       GitilesError: If there was an unexpected failure with the Gitiles service.
     """
     logging.warning('Loading Chromite configuration from: %s', url)
 
     try:
       # Force no authentication. Chromite is public! By default, 'requests' will
       # use 'netrc' for authentication. This can cause the load to fail if
       # the '.netrc' has an invalid entry, failing authentication.
-      return requests.get(
+      res = requests.get(
           url,
           verify=True,
-          auth=lambda r: r).text
+          auth=lambda r: r)
+      if res.status_code != 200:
+        raise GitilesError(
+            url, 'Unexpected HTTP status code %d; body: %s' % (
+              res.status_code, res.text))
+      return res.text
     except requests.exceptions.RequestException as e:
       raise GitilesError(url, 'Request raised exception: %s' % (e,))
 
   def __call__(self, name, version):
     """Returns: (str) the contents of a specified file from Gitiles.
 
     Args:
       name: (str) The artifact name. In this case, it's the pinned branch.
       version: (str) The requested version. In this case, it's a Git commit.
           If None, the pinned Git commit of the 'name' branch will be used.
@@ skipping 112 matching lines @@
 
 # Allow this script to be used as a bootstrap to fetch/cache Chromite
 # artifacts (gclient runhooks).
 if __name__ == '__main__':
   logging.basicConfig()
   try:
     sys.exit(main(sys.argv[1:], DefaultChromitePinManager))
   except Exception as e:
     logging.exception("Uncaught execption: %s", e)
   sys.exit(1)