Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2108713003: [sanitizers] stripping output path even if it is not named Release. (Closed)

Created:
4 years, 5 months ago by aizatsky
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sanitizers] stripping output path even if it is not named Release. This will also get rid of "libfuzzer/../../" strings in libfuzzer stacktraces. BUG= Committed: https://crrev.com/f10581ba67dd77e4229fcb509a6633410a8191ab Cr-Commit-Position: refs/heads/master@{#402623}

Patch Set 1 #

Patch Set 2 : [sanitizers] stripping output path even if it is not named Release. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M build/sanitizers/sanitizer_options.cc View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
aizatsky
4 years, 5 months ago (2016-06-28 22:18:52 UTC) #3
Evgeniy Stepanov
This may accidentally strip more than necessary, but I don't see a better way. LGTM
4 years, 5 months ago (2016-06-28 22:35:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108713003/20001
4 years, 5 months ago (2016-06-28 22:44:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/208987)
4 years, 5 months ago (2016-06-28 23:55:24 UTC) #9
eugenis
lgtm
4 years, 5 months ago (2016-06-29 00:00:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108713003/20001
4 years, 5 months ago (2016-06-29 00:04:15 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 00:47:33 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 00:49:11 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f10581ba67dd77e4229fcb509a6633410a8191ab
Cr-Commit-Position: refs/heads/master@{#402623}

Powered by Google App Engine
This is Rietveld 408576698