Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2108703002: mac: Send SIGTERM instead of SIGHUP to restart Dock (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Send SIGTERM instead of SIGHUP to restart Dock Dock swallows SIGHUP as of macOS 10.12. SIGTERM still works. BUG=620385 Committed: https://crrev.com/339ee572c21fa708c4eec78ecd2950b6263165e4 Cr-Commit-Position: refs/heads/master@{#402574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/mac/dock.mm View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Mark Mentovai
4 years, 5 months ago (2016-06-28 16:02:37 UTC) #3
Robert Sesek
lgtm
4 years, 5 months ago (2016-06-28 16:05:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108703002/1
4 years, 5 months ago (2016-06-28 16:08:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253914)
4 years, 5 months ago (2016-06-28 19:12:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108703002/1
4 years, 5 months ago (2016-06-28 19:18:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 22:25:31 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 22:27:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/339ee572c21fa708c4eec78ecd2950b6263165e4
Cr-Commit-Position: refs/heads/master@{#402574}

Powered by Google App Engine
This is Rietveld 408576698