Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2108683002: Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. When comparing large targets like //chrome, it is nearly impossible to deal with the mountainous 46,000 lines of output the executable script produces. With an interactive environment, it is much easier to compare differences and drill-down into specific issues. BUG=622889 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9f1375ea1bfb9f35e48b69f4c10c8ffa3233ca2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -202 lines) Patch
M tools/gn/bin/gyp_flag_compare.py View 6 chunks +333 lines, -202 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
4 years, 5 months ago (2016-06-28 15:43:02 UTC) #1
scottmg
lgtm
4 years, 5 months ago (2016-06-28 18:47:54 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9f1375ea1bfb9f35e48b69f4c10c8ffa3233ca2a Cr-Commit-Position: refs/heads/master@{#402512}
4 years, 5 months ago (2016-06-28 19:29:29 UTC) #4
Robert Sesek
Committed patchset #1 (id:1) manually as 9f1375ea1bfb9f35e48b69f4c10c8ffa3233ca2a (presubmit successful).
4 years, 5 months ago (2016-06-28 19:30:35 UTC) #6
Khushal
4 years, 5 months ago (2016-06-28 19:53:20 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2104083002/ by khushalsagar@chromium.org.

The reason for reverting is: A significant number of bots are broken after this
landed. This is a speculative revert. Please re-land in case this was not the
error..

Powered by Google App Engine
This is Rietveld 408576698