Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2108653002: Revert of Re-enable AppMenuTest#testChangingOrientationHidesMenu() (Closed)

Created:
4 years, 5 months ago by dgn
Modified:
4 years, 5 months ago
Reviewers:
Ted C, pkotwicz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable AppMenuTest#testChangingOrientationHidesMenu() (patchset #1 id:1 of https://codereview.chromium.org/2033883002/ ) Reason for revert: Flaky again on JB Tester and M Tablet Tester. Original issue's description: > Re-enable AppMenuTest#testChangingOrientationHidesMenu() > > BUG=458193 > > Committed: https://crrev.com/9bb4fadfacdb7962c3865f68370903b15f1fa9f4 > Cr-Commit-Position: refs/heads/master@{#397840} TBR=tedchoc@chromium.org,pkotwicz@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=458193 Committed: https://crrev.com/5dccb3c48f43b125249ae1cdd20678456b994e10 Cr-Commit-Position: refs/heads/master@{#402465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dgn
Created Revert of Re-enable AppMenuTest#testChangingOrientationHidesMenu()
4 years, 5 months ago (2016-06-28 13:51:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108653002/1
4 years, 5 months ago (2016-06-28 13:52:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 14:47:51 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 14:49:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dccb3c48f43b125249ae1cdd20678456b994e10
Cr-Commit-Position: refs/heads/master@{#402465}

Powered by Google App Engine
This is Rietveld 408576698