Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2108643007: Revert of arc: Implement silent OptIn mode for managed Arc. (Closed)

Created:
4 years, 5 months ago by victorhsieh0
Modified:
4 years, 5 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of arc: Implement silent OptIn mode for managed Arc. (patchset #4 id:60001 of https://codereview.chromium.org/2102793002/ ) Reason for revert: This change allows automatic auth code generation and is considered as risky in production. Original issue's description: > arc: Implement silent OptIn mode for managed Arc. > > BUG=b/28987931 > BUG=b/29121207 > TEST=Manually on device. In case Arc is managed no UI is shown and > Arc is started automatically. Emulate error and OptIn is > automatically recovered without user interaction. > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/146d8abde33c689871bd75b5057a753229657659 > Cr-Commit-Position: refs/heads/master@{#402635} TBR=xiyuan@chromium.org,khmel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/28987931 Committed: https://crrev.com/609d976c2ca9dd98d6f306bf5aa5cbc98c78092b Cr-Commit-Position: refs/heads/master@{#402918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -330 lines) Patch
M chrome/browser/chromeos/arc/arc_android_management_checker.h View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_android_management_checker.cc View 5 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_android_management_checker_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/chromeos/arc/arc_auth_context.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/chromeos/arc/arc_auth_context.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D chrome/browser/chromeos/arc/arc_auth_context_delegate.h View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.h View 6 chunks +32 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 12 chunks +67 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/arc_support/background.js View 9 chunks +4 lines, -61 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
victorhsieh0
Created Revert of arc: Implement silent OptIn mode for managed Arc.
4 years, 5 months ago (2016-06-29 20:01:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108643007/1
4 years, 5 months ago (2016-06-29 20:03:01 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-29 20:03:05 UTC) #5
Luis Héctor Chávez
lgtm
4 years, 5 months ago (2016-06-29 20:05:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108643007/1
4 years, 5 months ago (2016-06-29 20:07:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 20:08:34 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 20:12:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/609d976c2ca9dd98d6f306bf5aa5cbc98c78092b
Cr-Commit-Position: refs/heads/master@{#402918}

Powered by Google App Engine
This is Rietveld 408576698