content/browser/loader/resource_dispatcher_host_impl.h - Issue 2108643004: Remove use of WebContentsImpl from ResourceDispatcherHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.h

Issue 2108643004: Remove use of WebContentsImpl from ResourceDispatcherHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render-view-try-3

Patch Set: fix comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/navigation_url_loader_unittest.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_impl.h

diff --git a/content/browser/loader/resource_dispatcher_host_impl.h b/content/browser/loader/resource_dispatcher_host_impl.h

index 646fc2a3d940b313a2df00e41eee4180844df300..2b2d256c7584cafa817fbfb77fcd602ff32d2473 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.h

+++ b/content/browser/loader/resource_dispatcher_host_impl.h

@@ -70,7 +70,6 @@ class ResourceMessageFilter;

class ResourceRequestInfoImpl;

class SaveFileManager;

class ServiceWorkerNavigationHandleCore;

-class WebContentsImpl;

struct CommonNavigationParams;

struct DownloadSaveInfo;

struct NavigationRequestInfo;

@@ -217,7 +216,7 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl

// Force cancels any pending requests for the given process.

void CancelRequestsForProcess(int child_id);

- void OnUserGesture(WebContentsImpl* contents);

+ void OnUserGesture();

// Retrieves a net::URLRequest. Must be called from the IO thread.

net::URLRequest* GetURLRequest(const GlobalRequestID& request_id);

@@ -307,6 +306,8 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl

// or experiment status. For unit tests only.

void EnableStaleWhileRevalidateForTesting();

+ // Sets the LoaderDelegate, which must outlive this object. Ownership is not

+ // transferred. The LoaderDelegate should be interacted with on the IO thread.

void SetLoaderDelegate(LoaderDelegate* loader_delegate);

private: