Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.h

Issue 2108643004: Remove use of WebContentsImpl from ResourceDispatcherHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render-view-try-3
Patch Set: fixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.h
diff --git a/content/browser/loader/resource_dispatcher_host_impl.h b/content/browser/loader/resource_dispatcher_host_impl.h
index 646fc2a3d940b313a2df00e41eee4180844df300..89c20a582fea068823565676843120ed531b1b4e 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.h
+++ b/content/browser/loader/resource_dispatcher_host_impl.h
@@ -70,7 +70,6 @@ class ResourceMessageFilter;
class ResourceRequestInfoImpl;
class SaveFileManager;
class ServiceWorkerNavigationHandleCore;
-class WebContentsImpl;
struct CommonNavigationParams;
struct DownloadSaveInfo;
struct NavigationRequestInfo;
@@ -217,7 +216,7 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
// Force cancels any pending requests for the given process.
void CancelRequestsForProcess(int child_id);
- void OnUserGesture(WebContentsImpl* contents);
+ void OnUserGesture();
// Retrieves a net::URLRequest. Must be called from the IO thread.
net::URLRequest* GetURLRequest(const GlobalRequestID& request_id);
@@ -307,6 +306,9 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
// or experiment status. For unit tests only.
void EnableStaleWhileRevalidateForTesting();
+ // Sets the LoaderDelegate, which much outlive this object. Ownership is not
+ // transferred. The LoaderDelegate should be interacted with asynchronously,
+ // and on the IO thread.
mmenke 2016/06/29 22:05:20 Not sure what you mean by "asynchronously". If yo
scottmg 2016/06/29 22:16:19 I was trying to get across that it should eventual
void SetLoaderDelegate(LoaderDelegate* loader_delegate);
private:
« no previous file with comments | « content/browser/loader/navigation_url_loader_unittest.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698