Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2108643003: [GN] Add //build/config/compiler:wexit_time_destructors everywhere it is in GYP. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, msramek+watch_chromium.org, zea+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, jam, cbentzel+watch_chromium.org, raymes+watch_chromium.org, darin-cc_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, markusheintz_, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Add //build/config/compiler:wexit_time_destructors everywhere it is in GYP. BUG=622889 R=brettw@chromium.org Committed: https://crrev.com/99679aa7b04b20488f5e6669a74ddcc4ddbd8690 Cr-Commit-Position: refs/heads/master@{#402546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -6 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/service/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/utility/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M components/content_settings/core/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/child/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M google_apis/gcm/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M storage/common/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
4 years, 5 months ago (2016-06-28 19:33:57 UTC) #1
brettw
lgtm
4 years, 5 months ago (2016-06-28 19:59:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108643003/1
4 years, 5 months ago (2016-06-28 20:33:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 21:24:58 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 21:27:01 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/99679aa7b04b20488f5e6669a74ddcc4ddbd8690
Cr-Commit-Position: refs/heads/master@{#402546}

Powered by Google App Engine
This is Rietveld 408576698