Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2108643002: IOSChromeUpdatePasswordInfoBarDelegate for update password UI (Closed)

Created:
4 years, 5 months ago by Jackie Quinn
Modified:
4 years, 5 months ago
Reviewers:
vabr (Chromium), dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@update_metrics
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IOSChromeUpdatePasswordInfoBarDelegate for update password UI Adds IOSChromeUpdatePasswordInfoBarDelegate to serve as infobar delegate for the update password infobar. This delegate provides account data to the controller, indicating which account to display and whether there are multiple accounts possible for the pending password update. The controller created in Create will be changed to a custom controller for update passwords when the controller is available. BUG=622244 Committed: https://crrev.com/aad66ecb0cfcee57820f640e859f96d8fe198125 Cr-Commit-Position: refs/heads/master@{#403762}

Patch Set 1 #

Patch Set 2 : Separate out Delegate #

Total comments: 4

Patch Set 3 : Nit fixes #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -0 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h View 1 1 chunk +70 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm View 1 2 1 chunk +111 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Jackie Quinn
4 years, 5 months ago (2016-06-30 13:06:02 UTC) #3
vabr (Chromium)
LGTM, just nits. Thanks! Vaclav https://codereview.chromium.org/2108643002/diff/20001/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm File ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm (right): https://codereview.chromium.org/2108643002/diff/20001/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm#newcode1 ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm:1: // Copyright 2015 The ...
4 years, 5 months ago (2016-06-30 13:25:13 UTC) #4
Jackie Quinn
https://codereview.chromium.org/2108643002/diff/20001/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm File ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm (right): https://codereview.chromium.org/2108643002/diff/20001/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm#newcode1 ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm:1: // Copyright 2015 The Chromium Authors. All rights reserved. ...
4 years, 5 months ago (2016-06-30 13:54:32 UTC) #5
vabr (Chromium)
lgtm
4 years, 5 months ago (2016-06-30 14:29:04 UTC) #6
dvadym
lgtm, as far as I see the logic here is the same as for other ...
4 years, 5 months ago (2016-06-30 14:38:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108643002/60001
4 years, 5 months ago (2016-07-05 09:11:44 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-05 10:20:46 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 10:22:20 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/aad66ecb0cfcee57820f640e859f96d8fe198125
Cr-Commit-Position: refs/heads/master@{#403762}

Powered by Google App Engine
This is Rietveld 408576698