Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h

Issue 2108593002: Create superclass for IOSChromeSavePasswordInfobarDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review rd 2 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h
diff --git a/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h b/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h
index b3781078d43a723f9dffcf24094ac536797d8c21..3d9317422e754c2b34987c329b87f603f85b3f89 100644
--- a/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h
+++ b/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h
@@ -8,8 +8,7 @@
#include <memory>
#include "base/macros.h"
-#include "components/infobars/core/confirm_infobar_delegate.h"
-#include "components/password_manager/core/browser/password_manager_metrics_util.h"
+#include "ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h"
namespace password_manager {
class PasswordFormManager;
@@ -23,7 +22,8 @@ class InfoBarManager;
// password_manager::PasswordFormManager and move it to a
// IOSChromeSavePasswordInfoBarDelegate while the user makes up their mind
// with the "save password" infobar.
-class IOSChromeSavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate {
+class IOSChromeSavePasswordInfoBarDelegate
+ : public IOSChromePasswordManagerInfoBarDelegate {
public:
// Creates the infobar for |form_to_save| and adds it to |infobar_manager|.
// |is_smart_lock_enabled| controls the branding string.
@@ -40,25 +40,11 @@ class IOSChromeSavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate {
std::unique_ptr<password_manager::PasswordFormManager> form_to_save);
// ConfirmInfoBarDelegate implementation.
- Type GetInfoBarType() const override;
infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
base::string16 GetMessageText() const override;
- base::string16 GetLinkText() const override;
base::string16 GetButtonLabel(InfoBarButton button) const override;
bool Accept() override;
bool Cancel() override;
- int GetIconId() const override;
- bool LinkClicked(WindowOpenDisposition disposition) override;
-
- // The password_manager::PasswordFormManager managing the form we're asking
- // the user about, and should update as per her decision.
- std::unique_ptr<password_manager::PasswordFormManager> form_to_save_;
-
- // Used to track the results we get from the info bar.
- password_manager::metrics_util::UIDismissalReason infobar_response_;
-
- // Whether to show the password manager branded as Smart Lock.
- bool is_smart_lock_branding_enabled_;
DISALLOW_COPY_AND_ASSIGN(IOSChromeSavePasswordInfoBarDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698