third_party/buildbot_8_4p1/buildbot/db/pool.py - Issue 2108563002: Cherry-pick buildbot de928a17f52dd91e17fab66d1cd5a60eed6aa360:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/buildbot_8_4p1/buildbot/db/pool.py

Issue 2108563002: Cherry-pick buildbot de928a17f52dd91e17fab66d1cd5a60eed6aa360: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@buildbot-workaround-1

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/buildbot_8_4p1/buildbot/db/pool.py

diff --git a/third_party/buildbot_8_4p1/buildbot/db/pool.py b/third_party/buildbot_8_4p1/buildbot/db/pool.py

index ea3df35af4e7b6f2b3c91b5758178bbc1cd34ef0..270243d4e855f1a1dda1edc5e3fa390e7614e22c 100644

--- a/third_party/buildbot_8_4p1/buildbot/db/pool.py

+++ b/third_party/buildbot_8_4p1/buildbot/db/pool.py

@@ -50,6 +50,10 @@ class DBThreadPool(threadpool.ThreadPool):

if engine.dialect.name == 'sqlite':

vers = self.get_sqlite_version()

log.msg("Using SQLite Version %s" % (vers,))

+ if vers < (3,7):

+ log.msg("NOTE: this old version of SQLite does not support "

+ "WAL journal mode; a busy master may encounter "

+ "'Database is locked' errors. Consider upgrading.")

if vers < (3,3,17):

log.msg("NOTE: this old version of SQLite does not support "

"multiple simultaneous accesses to the database; "

« no previous file with comments | « no previous file | no next file » | no next file with comments »