Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2108553003: Removed DCHECK(IsEncryptionEstablished()) (Closed)

Created:
4 years, 5 months ago by kapishnikov
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed DCHECK(IsEncryptionEstablished()) BUG=621091 Committed: https://crrev.com/15315986badb434e679db773c1965336b626c448 Cr-Commit-Position: refs/heads/master@{#402808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M net/quic/quic_chromium_client_session.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
kapishnikov
4 years, 5 months ago (2016-06-28 22:12:17 UTC) #2
kapishnikov
On 2016/06/28 22:12:17, kapishnikov wrote: Helen, could you please review this one line change?
4 years, 5 months ago (2016-06-28 22:14:20 UTC) #3
xunjieli
lgtm although I am not a QUIC owner. Ryan: mind taking a look?
4 years, 5 months ago (2016-06-28 22:14:33 UTC) #5
Ryan Hamilton
lgtm
4 years, 5 months ago (2016-06-28 22:57:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108553003/1
4 years, 5 months ago (2016-06-29 13:54:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 14:59:48 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 14:59:59 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 15:01:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15315986badb434e679db773c1965336b626c448
Cr-Commit-Position: refs/heads/master@{#402808}

Powered by Google App Engine
This is Rietveld 408576698