Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2108553002: Revert buildbot 361b81b43fc7793b66facd4bac7abe0adb30f3d5. (Closed)

Created:
4 years, 5 months ago by dsansome
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert buildbot 361b81b43fc7793b66facd4bac7abe0adb30f3d5. This commit was only added in the 0.8.4 branch, and was never made to master. The bug only happens when starting buildbot with "make start", but we start it directly with twistd in Chrome: http://trac.buildbot.net/ticket/1992 BUG=620572 Committed: https://chromium.googlesource.com/chromium/tools/build/+/8c7a5b159b444e0193f9b2d8a094d352c226e7d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M third_party/buildbot_8_4p1/buildbot/db/pool.py View 5 chunks +1 line, -24 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
dsansome
4 years, 5 months ago (2016-06-28 08:04:56 UTC) #3
ghost stip (do not use)
lgtm
4 years, 5 months ago (2016-07-01 01:23:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108553002/1
4 years, 5 months ago (2016-07-01 03:58:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/8c7a5b159b444e0193f9b2d8a094d352c226e7d1
4 years, 5 months ago (2016-07-01 04:02:00 UTC) #8
ghost stip (do not use)
4 years, 5 months ago (2016-07-07 20:46:13 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2128963002/ by stip@chromium.org.

The reason for reverting is: possible cause of
https://bugs.chromium.org/p/chromium/issues/detail?id=626354..

Powered by Google App Engine
This is Rietveld 408576698