Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2108543002: X87: [builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of TailCallRuntime. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of TailCallRuntime. port b5c69cbf39192b7efc12ae40406c8bd55a44419b (r37132) original commit message: With the tail call, pointers to the JS heap could be pushed on a js-to-wasm frame. On the js-to-wasm frame, however, this pointer would not be updated by the GC. BUG= Committed: https://crrev.com/90fa326a6cb97c6465b9252753b61c28c0426286 Cr-Commit-Position: refs/heads/master@{#37319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-28 06:25:32 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-28 06:34:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108543002/1
4 years, 5 months ago (2016-06-28 08:32:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 08:56:05 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 08:57:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90fa326a6cb97c6465b9252753b61c28c0426286
Cr-Commit-Position: refs/heads/master@{#37319}

Powered by Google App Engine
This is Rietveld 408576698