Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2108533002: Ship Shadow DOM v1 (Closed)

Created:
4 years, 5 months ago by hayato
Modified:
4 years, 5 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship Shadow DOM v1 Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/zrZRD2ls5tw/ibbjD3cQAQAJ BUG=531990 Committed: https://crrev.com/97235496c3dee67efb24f9a7893232df493dcd1e Cr-Commit-Position: refs/heads/master@{#402723}

Patch Set 1 #

Patch Set 2 : Depends removal of Node.rootNode #

Patch Set 3 : rebased #

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108533002/1
4 years, 5 months ago (2016-06-28 02:15:11 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253497)
4 years, 5 months ago (2016-06-28 03:32:26 UTC) #4
hayato
Depends removal of Node.rootNode
4 years, 5 months ago (2016-06-28 04:37:35 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108533002/20001
4 years, 5 months ago (2016-06-28 04:37:43 UTC) #7
hayato
PTAL. This cl depends on https://codereview.chromium.org/2106683002/.
4 years, 5 months ago (2016-06-28 04:43:23 UTC) #9
tkent
lgtm
4 years, 5 months ago (2016-06-28 04:46:20 UTC) #10
kochi
yeah LGTM
4 years, 5 months ago (2016-06-28 05:00:09 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253549)
4 years, 5 months ago (2016-06-28 05:57:50 UTC) #13
hayato
rebased
4 years, 5 months ago (2016-06-29 03:27:17 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108533002/40001
4 years, 5 months ago (2016-06-29 03:27:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108533002/40001
4 years, 5 months ago (2016-06-29 03:27:51 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 04:56:11 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 04:57:52 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/97235496c3dee67efb24f9a7893232df493dcd1e
Cr-Commit-Position: refs/heads/master@{#402723}

Powered by Google App Engine
This is Rietveld 408576698