src/api.cc - Issue 210853003: Revert "Ship promises and weak collections"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 210853003: Revert "Ship promises and weak collections" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index ef627d027f6475b03760d621ddb5dbe271ac54e3..ea2edbce9cbe77a1d1c9d03f0092d7e50e5cd63f 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -5832,7 +5832,7 @@ Local<Object> Array::CloneElementAt(uint32_t index) {

bool Value::IsPromise() const {

i::Handle<i::Object> val = Utils::OpenHandle(this);

- if (!val->IsJSObject()) return false;

+ if (!i::FLAG_harmony_promises || !val->IsJSObject()) return false;

i::Handle<i::JSObject> obj = i::Handle<i::JSObject>::cast(val);

i::Isolate* isolate = obj->GetIsolate();

LOG_API(isolate, "IsPromise");

« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »