Issue 210853003: Revert "Ship promises and weak collections"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210853003: Revert "Ship promises and weak collections" (Closed)

Created:
6 years, 9 months ago by rossberg

Modified:
6 years, 9 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Ship promises and weak collections" Reason: breaks Blink layout tests. R=machenbach@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20233

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -234 lines)			Patch
M	src/api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/bootstrapper.cc	View	8 chunks	+25 lines, -23 lines	0 comments	Download
M	src/flag-definitions.h	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/promise.js	View	7 chunks	+22 lines, -19 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-microtask-delivery.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/debug-script.js	View	1 chunk	+1 line, -1 line	0 comments	Download
D	test/mjsunit/es6/microtask-delivery.js	View	1 chunk	+0 lines, -168 lines	0 comments	Download
M	test/mjsunit/es6/promises.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/es6/regress/regress-2034.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/es6/regress/regress-2156.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/es6/regress/regress-2829.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/es6/weak_collections.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/es7/object-observe.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mjsunit/harmony/collections.js	View	2 chunks	+7 lines, -8 lines	0 comments	Download
A +	test/mjsunit/harmony/microtask-delivery.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/harmony/private.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/harmony/proxies-hash.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/harmony/regress/regress-observe-empty-double-array.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/harmony/symbols.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-crbug-350864.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

6 years, 9 months ago (2014-03-25 10:58:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20233 (tree was closed).

Expand Messages | Collapse Messages