Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 210853002: Oilpan: Prepare to move DatabaseAuthorizer to Oilpan heap. (Closed)

Created:
6 years, 9 months ago by tkent
Modified:
6 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Visibility:
Public.

Description

Oilpan: Prepare to move DatabaseAuthorizer to Oilpan heap. Note: This CL changes the argument type of SQLiteDatabase::setAuthorizer from PassRefPtr<DatabaseAuthorizer> to DatabaseAuthorizer*. We don't need to use PassRefPtr<> here. BUG=347902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M Source/modules/webdatabase/DatabaseAuthorizer.h View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseAuthorizer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteDatabase.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tkent
Please review this.
6 years, 9 months ago (2014-03-25 09:25:40 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-25 09:30:58 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-25 09:31:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/210853002/1
6 years, 9 months ago (2014-03-25 09:31:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 10:27:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 10:27:56 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-25 10:30:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/210853002/1
6 years, 9 months ago (2014-03-25 10:30:46 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 11:30:32 UTC) #9
Message was sent while issue was closed.
Change committed as 169930

Powered by Google App Engine
This is Rietveld 408576698