Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2108503007: Switch to faster enter/exit animations for herb tabs. (Closed)

Created:
4 years, 5 months ago by Ted C
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to faster enter/exit animations for herb tabs. These match the in app activity transitions in Android. BUG=613685 Committed: https://crrev.com/c291a147378f97d88f3f6d0d01e4d2bf19540210 Cr-Commit-Position: refs/heads/master@{#403360}

Patch Set 1 #

Total comments: 4

Patch Set 2 : New all the lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -38 lines) Patch
A + chrome/android/java/res/anim/accelerate_quart.xml View 1 chunk +3 lines, -6 lines 0 comments Download
A chrome/android/java/res/anim/activity_close_exit.xml View 1 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/android/java/res/anim/activity_open_enter.xml View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + chrome/android/java/res/anim/decelerate_quart.xml View 1 chunk +3 lines, -6 lines 0 comments Download
D chrome/android/java/res/anim/slide_in_up.xml View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/android/java/res/anim/slide_out_down.xml View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Ted C
PTAL
4 years, 5 months ago (2016-06-30 23:05:38 UTC) #2
gone
lgtm https://codereview.chromium.org/2108503007/diff/1/chrome/android/java/res/anim/activity_close_exit.xml File chrome/android/java/res/anim/activity_close_exit.xml (right): https://codereview.chromium.org/2108503007/diff/1/chrome/android/java/res/anim/activity_close_exit.xml#newcode9 chrome/android/java/res/anim/activity_close_exit.xml:9: android:shareInterpolator="false" android:zAdjustment="top"> nit: move android:zAdjustment to newline https://codereview.chromium.org/2108503007/diff/1/chrome/android/java/res/anim/activity_open_enter.xml ...
4 years, 5 months ago (2016-06-30 23:26:20 UTC) #3
Ted C
https://codereview.chromium.org/2108503007/diff/1/chrome/android/java/res/anim/activity_close_exit.xml File chrome/android/java/res/anim/activity_close_exit.xml (right): https://codereview.chromium.org/2108503007/diff/1/chrome/android/java/res/anim/activity_close_exit.xml#newcode9 chrome/android/java/res/anim/activity_close_exit.xml:9: android:shareInterpolator="false" android:zAdjustment="top"> On 2016/06/30 23:26:20, dfalcantara wrote: > nit: ...
4 years, 5 months ago (2016-06-30 23:29:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108503007/20001
4 years, 5 months ago (2016-06-30 23:30:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 00:12:43 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 00:12:58 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 00:15:42 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c291a147378f97d88f3f6d0d01e4d2bf19540210
Cr-Commit-Position: refs/heads/master@{#403360}

Powered by Google App Engine
This is Rietveld 408576698