Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2108503006: Fix layout test to not rely on function ctor from detached frame (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layout test to not rely on function ctor from detached frame I'm planning to restrict this behavior, so I'm rewriting the test such that it still tests what it's supposed to test. BUG=541703 R=mkwst@chromium.org Committed: https://crrev.com/61c0cda87e4c1d5a1fb0106e8ae12c8938ee46ac Cr-Commit-Position: refs/heads/master@{#403768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/location-change-from-detached-DOMWindow.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-06-30 09:24:02 UTC) #1
Mike West
LGTM!
4 years, 5 months ago (2016-07-04 08:51:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108503006/1
4 years, 5 months ago (2016-07-05 08:35:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/250142)
4 years, 5 months ago (2016-07-05 09:08:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108503006/1
4 years, 5 months ago (2016-07-05 10:40:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 11:37:21 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 11:38:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61c0cda87e4c1d5a1fb0106e8ae12c8938ee46ac
Cr-Commit-Position: refs/heads/master@{#403768}

Powered by Google App Engine
This is Rietveld 408576698