Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Issue 2108503004: Dump batch bounds and scissor rect (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update to match B.'s formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/gpu/batches/GrBatch.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/gpu/batches/GrClearBatch.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrDiscardBatch.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/batches/GrStencilPathBatch.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108503004/1
4 years, 5 months ago (2016-06-28 22:03:10 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 22:19:27 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108503004/20001
4 years, 5 months ago (2016-06-29 13:13:42 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 13:36:08 UTC) #11
bsalomon
lgtm
4 years, 5 months ago (2016-06-29 13:46:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108503004/20001
4 years, 5 months ago (2016-06-29 13:55:16 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 13:56:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/44fbc79e069c28103a44387d11c62e049ef2967d

Powered by Google App Engine
This is Rietveld 408576698