Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2108423002: Revert of Apply Referrer-Policy header when following redirects (Closed)

Created:
4 years, 5 months ago by estark
Modified:
4 years, 5 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, Mike West
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Apply Referrer-Policy header when following redirects (patchset #17 id:320001 of https://codereview.chromium.org/2100583002/ ) Reason for revert: Broke msan tests https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/17218/steps/net_unittests%20on%20Ubuntu-12.04/logs/URLRequestJob.RedirectTransactionWithReferrerPolicyHeader Original issue's description: > Apply Referrer-Policy header when following redirects > > When a Referrer-Policy header is received during a redirect, > URLRequestJob parses it and updates the referrer and referrer policy on > the request, if necessary. > > The Referrer-Policy header is being implemented as an experimental web > platform feature. The experimental web platform feature flag is plumbed > to URLRequestJob via a boolean on URLRequestContext. This flag should be > temporary and only live until the Referrer-Policy feature ships. > > Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70 > Implementation plan: https://docs.google.com/document/d/1SyQhP6Y7BHIQXWL8S1saWqMuar4hoWLGigQuHmizg3g/edit > > BUG=619228 > > Committed: https://crrev.com/550ba7f9533922cfeac9709d99815cec9b2ad52a > Cr-Commit-Position: refs/heads/master@{#403017} TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619228 Committed: https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8 Cr-Commit-Position: refs/heads/master@{#403075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -410 lines) Patch
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_url_request_context_getter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_url_request_context_getter.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M ios/web/public/referrer_util_unittest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M net/url_request/redirect_info.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/url_request/redirect_info.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/url_request/url_request.h View 1 chunk +16 lines, -20 lines 0 comments Download
M net/url_request/url_request.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M net/url_request/url_request_context.h View 2 chunks +0 lines, -13 lines 0 comments Download
M net/url_request/url_request_context.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/url_request/url_request_job.cc View 5 chunks +3 lines, -69 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 3 chunks +0 lines, -221 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/referrer-policy-redirect.php View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/resources/header-test.js View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/resources/no-referrer-on-redirect.php View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/resources/postmessage-referrer.php View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
estark
Created Revert of Apply Referrer-Policy header when following redirects
4 years, 5 months ago (2016-06-30 02:57:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108423002/1
4 years, 5 months ago (2016-06-30 02:58:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 02:59:11 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8 Cr-Commit-Position: refs/heads/master@{#403075}
4 years, 5 months ago (2016-06-30 03:00:29 UTC) #6
estark
4 years, 5 months ago (2016-06-30 16:56:57 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2111623003/ by estark@chromium.org.

The reason for reverting is: Relanding after fixing uninitialized |read_handler|
field in MockTransaction.

Powered by Google App Engine
This is Rietveld 408576698