Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2108413002: Revert of Switch chrome_elf exception handling from breakpad to crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_exe_main_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 {"ppapi_path", kMediumSize}, 95 {"ppapi_path", kMediumSize},
96 {"subresource_url", kLargeSize}, 96 {"subresource_url", kLargeSize},
97 {"total-discardable-memory-allocated", kSmallSize}, 97 {"total-discardable-memory-allocated", kSmallSize},
98 {kBug464926CrashKey, kSmallSize}, 98 {kBug464926CrashKey, kSmallSize},
99 {kViewCount, kSmallSize}, 99 {kViewCount, kSmallSize},
100 100
101 // media/: 101 // media/:
102 {kHungAudioThreadDetails, kSmallSize}, 102 {kHungAudioThreadDetails, kSmallSize},
103 {kZeroEncodeDetails, kSmallSize}, 103 {kZeroEncodeDetails, kSmallSize},
104 104
105 // gin/:
106 { "v8-ignition", kSmallSize },
107
108 // Temporary for http://crbug.com/575245. 105 // Temporary for http://crbug.com/575245.
109 {"swapout_frame_id", kSmallSize}, 106 {"swapout_frame_id", kSmallSize},
110 {"swapout_proxy_id", kSmallSize}, 107 {"swapout_proxy_id", kSmallSize},
111 {"swapout_view_id", kSmallSize}, 108 {"swapout_view_id", kSmallSize},
112 {"commit_frame_id", kSmallSize}, 109 {"commit_frame_id", kSmallSize},
113 {"commit_proxy_id", kSmallSize}, 110 {"commit_proxy_id", kSmallSize},
114 {"commit_view_id", kSmallSize}, 111 {"commit_view_id", kSmallSize},
115 {"commit_main_render_frame_id", kSmallSize}, 112 {"commit_main_render_frame_id", kSmallSize},
116 {"newproxy_proxy_id", kSmallSize}, 113 {"newproxy_proxy_id", kSmallSize},
117 {"newproxy_view_id", kSmallSize}, 114 {"newproxy_view_id", kSmallSize},
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 bool ChromeCrashReporterClient::GetCollectStatsConsent() { 331 bool ChromeCrashReporterClient::GetCollectStatsConsent() {
335 return install_static::GetCollectStatsConsent(); 332 return install_static::GetCollectStatsConsent();
336 } 333 }
337 334
338 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 335 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
339 const std::string& process_type) { 336 const std::string& process_type) {
340 return process_type == install_static::kRendererProcess || 337 return process_type == install_static::kRendererProcess ||
341 process_type == install_static::kPpapiPluginProcess || 338 process_type == install_static::kPpapiPluginProcess ||
342 process_type == install_static::kGpuProcess; 339 process_type == install_static::kGpuProcess;
343 } 340 }
OLDNEW
« no previous file with comments | « no previous file | chrome/app/chrome_exe_main_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698