Move GrNonAAFillRectPerspectiveBatch to its own file

Move GrNonAAFillRectPerspectiveBatch to its own file

Get this out of the way of the upcoming changes (and add a test for it)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108403005

Committed: https://skia.googlesource.com/skia/+/01a19504c4dbd980e96b1c5b9fe8c8779432488d

[robertphillips, 2016-07-01 20:19:11]

Description was changed from

==========
Move GrNonAAFillRectPerspectiveBatch to its own file
==========

to

==========
Move GrNonAAFillRectPerspectiveBatch to its own file
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108403005
==========

[robertphillips, 2016-07-01 20:19:47]

Description was changed from

==========
Move GrNonAAFillRectPerspectiveBatch to its own file
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108403005
==========

to

==========
Move GrNonAAFillRectPerspectiveBatch to its own file

Get this out of the way of the upcoming changes (and add a test for it)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108403005
==========

[robertphillips, 2016-07-01 20:19:47]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-07-01 20:19:58]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 20:20:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 20:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 20:24:38]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[bsalomon, 2016-07-02 00:45:28]

lgtm

https://codereview.chromium.org/2108403005/diff/1/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/2108403005/diff/1/src/gpu/GrTestUtils.cpp#new...
src/gpu/GrTestUtils.cpp:17: static const SkMatrix& test_matrix(SkRandom* random,
bool includeNonPerspective, bool includePerspective) {
wrap?

https://codereview.chromium.org/2108403005/diff/1/src/gpu/batches/GrNonAAFill...
File src/gpu/batches/GrNonAAFillRectPerspectiveBatch.cpp (right):

https://codereview.chromium.org/2108403005/diff/1/src/gpu/batches/GrNonAAFill...
src/gpu/batches/GrNonAAFillRectPerspectiveBatch.cpp:93: class
GrNonAAFillRectPerspectiveBatch : public GrVertexBatch {
Why Gr?

[robertphillips, 2016-07-06 15:23:50]

https://codereview.chromium.org/2108403005/diff/1/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/2108403005/diff/1/src/gpu/GrTestUtils.cpp#new...
src/gpu/GrTestUtils.cpp:17: static const SkMatrix& test_matrix(SkRandom* random,
bool includeNonPerspective, bool includePerspective) {
On 2016/07/02 00:45:28, bsalomon wrote:
> wrap?

Done.

https://codereview.chromium.org/2108403005/diff/1/src/gpu/batches/GrNonAAFill...
File src/gpu/batches/GrNonAAFillRectPerspectiveBatch.cpp (right):

https://codereview.chromium.org/2108403005/diff/1/src/gpu/batches/GrNonAAFill...
src/gpu/batches/GrNonAAFillRectPerspectiveBatch.cpp:93: class
GrNonAAFillRectPerspectiveBatch : public GrVertexBatch {
On 2016/07/02 00:45:28, bsalomon wrote:
> Why Gr?

Down the road creating the non-AA batches in GrRectBatchFactory::CreateNonAAFill
no longer makes sense (since higher level code needs some input into which batch
gets created because of when we can fuse the rect with the clip). Due to this we
will probably have separate CreateRectStaysRectNonAAFill, CreatePerspNonAAFill
and CreateNonAAFill methods on GrRectBatchFactory. Each such method normally
calls create on the appropriate Gr*RectBatch class. Thus I've promoted this guy
to full Gr-hood in preparation for that.

[robertphillips, 2016-07-06 15:24:12]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 15:24:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 15:54:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 15:54:42]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-07-06 15:59:15]

lgtm

[robertphillips, 2016-07-06 16:57:50]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-07-06 16:57:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 16:58:59]

Description was changed from

==========
Move GrNonAAFillRectPerspectiveBatch to its own file

Get this out of the way of the upcoming changes (and add a test for it)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108403005
==========

to

==========
Move GrNonAAFillRectPerspectiveBatch to its own file

Get this out of the way of the upcoming changes (and add a test for it)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108403005

Committed:
https://skia.googlesource.com/skia/+/01a19504c4dbd980e96b1c5b9fe8c8779432488d
==========

[commit-bot: I haz the power, 2016-07-06 16:59:00]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/01a19504c4dbd980e96b1c5b9fe8c8779432488d

[commit-bot: I haz the power, 2016-07-06 16:59:02]

CQ bit was unchecked.