third_party/WebKit/Source/core/html/HTMLMediaElement.h - Issue 2108403003: Measure whether muted videos that started playing with play() become visible at some point

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 2108403003: Measure whether muted videos that started playing with play() become visible at some point (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: this one is ready Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp ('K') | « third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

index 9863e39251d31afb640160653852f921101638df..cd3615f7a7a8ac351e1237deb4570cb1d76dbd34 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

@@ -44,8 +44,11 @@

namespace blink {

+enum class AutoplaySource;

class AudioSourceProviderClient;

class AudioTrackList;

+class AutoplayUmaHelper;

class ContentType;

class CueTimeline;

class ElementVisibilityObserver;

@@ -499,7 +502,7 @@ private:

EnumerationHistogram& showControlsHistogram() const;

- void recordAutoplaySourceMetric(int source);

+ void recordAutoplaySourceMetric(AutoplaySource);

void recordAutoplayUnmuteStatus(AutoplayUnmuteActionStatus);

void onVisibilityChangedForAutoplay(bool isVisible);

@@ -678,6 +681,7 @@ private:

Member<AutoplayExperimentHelper::Client> m_autoplayHelperClient;

Member<AutoplayExperimentHelper> m_autoplayHelper;

+ Member<AutoplayUmaHelper> m_autoplayUmaHelper;

WebRemotePlaybackClient* m_remotePlaybackClient;