Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/log.cc

Issue 2108393002: Split Ticker into two samplers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: update Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/profiler/cpu-profiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 9f85213c3b7ea206705632a1640c302f62dec836..cb4e45ea7b3ab93e66febf0736f1555f537bec12 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -644,6 +644,7 @@ class Ticker: public sampler::Sampler {
}
void SampleStack(const v8::RegisterState& state) override {
+ if (!profiler_) return;
v8::Isolate* v8_isolate = isolate();
Isolate* isolate = reinterpret_cast<Isolate*>(v8_isolate);
#if defined(USE_SIMULATOR)
@@ -651,18 +652,9 @@ class Ticker: public sampler::Sampler {
const_cast<v8::RegisterState*>(&state)))
return;
#endif
- TickSample* sample = isolate->cpu_profiler()->StartTickSample();
- TickSample sample_obj;
- if (sample == NULL) sample = &sample_obj;
- sample->Init(isolate, state, TickSample::kIncludeCEntryFrame, true);
- if (is_counting_samples_ && !sample->timestamp.IsNull()) {
- if (sample->state == JS) ++js_sample_count_;
- if (sample->state == EXTERNAL) ++external_sample_count_;
- }
- if (profiler_) profiler_->Insert(sample);
- if (sample != &sample_obj) {
- isolate->cpu_profiler()->FinishTickSample();
- }
+ TickSample sample;
+ sample.Init(isolate, state, TickSample::kIncludeCEntryFrame, true);
+ profiler_->Insert(&sample);
}
private:
« no previous file with comments | « no previous file | src/profiler/cpu-profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698