src/profiler/cpu-profiler-inl.h - Issue 2108393002: Split Ticker into two samplers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/cpu-profiler-inl.h

Issue 2108393002: Split Ticker into two samplers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: address nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profiler/cpu-profiler-inl.h

diff --git a/src/profiler/cpu-profiler-inl.h b/src/profiler/cpu-profiler-inl.h

index d8c9c909c292390b9a288a1812824115cc4ec6c4..504c3f6e1ac86406578539955d64917f34250038 100644

--- a/src/profiler/cpu-profiler-inl.h

+++ b/src/profiler/cpu-profiler-inl.h

@@ -50,17 +50,6 @@ void ReportBuiltinEventRecord::UpdateCodeMap(CodeMap* code_map) {

}

-TickSample* CpuProfiler::StartTickSample() {

- if (is_profiling_) return processor_->StartTickSample();

- return NULL;

-void CpuProfiler::FinishTickSample() {

- processor_->FinishTickSample();

TickSample* ProfilerEventsProcessor::StartTickSample() {

void* address = ticks_buffer_.StartEnqueue();

if (address == NULL) return NULL;