Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2108363002: Fix null deref when hiding the PIN keyboard. (Closed)

Created:
4 years, 5 months ago by jdufault
Modified:
4 years, 5 months ago
Reviewers:
sammiequon, xiyuan
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix null deref when hiding the PIN keyboard. BUG=624193 Committed: https://crrev.com/7386c581f1a62b85a1bd1d0224d0414a7dad0d9f Cr-Commit-Position: refs/heads/master@{#402988}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Don't log PII #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M ui/login/account_picker/screen_account_picker.js View 1 chunk +1 line, -10 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 1 chunk +18 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jdufault
Sammie, Xiyuan, PTAL. Thanks!
4 years, 5 months ago (2016-06-29 21:29:29 UTC) #3
xiyuan
https://codereview.chromium.org/2108363002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2108363002/diff/1/ui/login/account_picker/user_pod_row.js#newcode2585 ui/login/account_picker/user_pod_row.js:2585: ' for missing pod ' + JSON.stringify(username) + '.'); ...
4 years, 5 months ago (2016-06-29 21:53:35 UTC) #4
jdufault
https://codereview.chromium.org/2108363002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2108363002/diff/1/ui/login/account_picker/user_pod_row.js#newcode2585 ui/login/account_picker/user_pod_row.js:2585: ' for missing pod ' + JSON.stringify(username) + '.'); ...
4 years, 5 months ago (2016-06-29 22:05:32 UTC) #5
xiyuan
lgtm Thanks.
4 years, 5 months ago (2016-06-29 22:06:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108363002/20001
4 years, 5 months ago (2016-06-29 22:11:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 23:15:55 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 23:18:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7386c581f1a62b85a1bd1d0224d0414a7dad0d9f
Cr-Commit-Position: refs/heads/master@{#402988}

Powered by Google App Engine
This is Rietveld 408576698