Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2108333003: Ensuring BACK key is getting passed to IMM before handling by Omnibox (Closed)

Created:
4 years, 5 months ago by AKV
Modified:
4 years, 5 months ago
Reviewers:
Ted C, Changwan Ryu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensuring BACK key is getting passed to IMM before handling by Omnibox Currently IMM is not getting BACK key event correctly, hence the IMM behavior on back key is not getting executed. Now made it sure that IMM will get the key event first before reaching to view. BUG=470001 Committed: https://crrev.com/daf34b45a957f1b61069fc2356ab8bc4a38c5c97 Cr-Commit-Position: refs/heads/master@{#403221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 5 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
AKV
PTAL!
4 years, 5 months ago (2016-06-30 11:32:51 UTC) #3
AKV
+ Changwan, who noticed this problem earlier in other Chrome files.
4 years, 5 months ago (2016-06-30 12:29:19 UTC) #5
Yaron
removing myself as I'm not a good reviewer for this change
4 years, 5 months ago (2016-06-30 13:08:29 UTC) #7
Ted C
lgtm
4 years, 5 months ago (2016-06-30 16:39:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108333003/1
4 years, 5 months ago (2016-06-30 17:16:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 18:04:19 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 18:07:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/daf34b45a957f1b61069fc2356ab8bc4a38c5c97
Cr-Commit-Position: refs/heads/master@{#403221}

Powered by Google App Engine
This is Rietveld 408576698