Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1929)

Unified Diff: Source/modules/webdatabase/SQLStatement.cpp

Issue 210833005: Oilpan: Prepare to move SQLError to oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: apply comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webdatabase/SQLError.idl ('k') | Source/modules/webdatabase/SQLStatementBackend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webdatabase/SQLStatement.cpp
diff --git a/Source/modules/webdatabase/SQLStatement.cpp b/Source/modules/webdatabase/SQLStatement.cpp
index 1d883fde2606b5b3fb52487f02f9cc7c73c12db1..539441b2072c22c03319df68b89178ca98aad8b5 100644
--- a/Source/modules/webdatabase/SQLStatement.cpp
+++ b/Source/modules/webdatabase/SQLStatement.cpp
@@ -79,13 +79,15 @@ bool SQLStatement::performCallback(SQLTransaction* transaction)
OwnPtr<SQLStatementCallback> callback = m_statementCallbackWrapper.unwrap();
OwnPtr<SQLStatementErrorCallback> errorCallback = m_statementErrorCallbackWrapper.unwrap();
- RefPtr<SQLError> error = m_backend->sqlError();
+ SQLErrorData* error = m_backend->sqlError();
// Call the appropriate statement callback and track if it resulted in an error,
// because then we need to jump to the transaction error callback.
if (error) {
- if (errorCallback)
- callbackError = errorCallback->handleEvent(transaction, error.get());
+ if (errorCallback) {
+ RefPtrWillBeRawPtr<SQLError> sqlError = SQLError::create(*error);
+ callbackError = errorCallback->handleEvent(transaction, sqlError.get());
+ }
} else if (callback) {
RefPtrWillBeRawPtr<SQLResultSet> resultSet = m_backend->sqlResultSet();
callbackError = !callback->handleEvent(transaction, resultSet.get());
« no previous file with comments | « Source/modules/webdatabase/SQLError.idl ('k') | Source/modules/webdatabase/SQLStatementBackend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698