Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 210833004: Inform the client when the Service Worker rejects an install event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 210833004: Inform the client when the Service Worker rejects an install event (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: use m_hasError in WaitUntilObserver Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index 10b5cff59cf7575a133eb5fb2d86729c59e4e250..b17885bbacca5957f98e60a057e610dbc238a934 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -48,10 +48,10 @@ ServiceWorkerGlobalScopeClientImpl::~ServiceWorkerGlobalScopeClientImpl()

{

}

-void ServiceWorkerGlobalScopeClientImpl::didHandleInstallEvent(int installEventID)

+void ServiceWorkerGlobalScopeClientImpl::didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult result)

{

if (m_client)

- m_client->didHandleInstallEvent(installEventID);

+ m_client->didHandleInstallEvent(installEventID, result);

}

void ServiceWorkerGlobalScopeClientImpl::didHandleFetchEvent(int fetchEventID, PassRefPtr<WebCore::Response> response)