Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 210833004: Inform the client when the Service Worker rejects an install event (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
index 4b01763f0c3fd90706e5dd6b34bc2665b9cc23cb..5f1cded227000add6e739521a53c9f54db52d489 100644
--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
@@ -46,7 +46,7 @@ class ServiceWorkerGlobalScopeClient : public Supplement<WorkerClients> {
public:
virtual ~ServiceWorkerGlobalScopeClient() { }
- virtual void didHandleInstallEvent(int installEventID) = 0;
+ virtual void didHandleInstallEvent(int installEventID, bool rejected) = 0;
dominicc (has gone to gerrit) 2014/03/26 01:23:15 Would it be better to introduce an enum for reject
falken 2014/03/26 07:26:36 Done.
// A null response means no valid response was provided by the service worker, so fallback to native.
virtual void didHandleFetchEvent(int fetchEventID, PassRefPtr<Response> = nullptr) = 0;
« no previous file with comments | « no previous file | Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | Source/modules/serviceworkers/WaitUntilObserver.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698