Source/modules/serviceworkers/WaitUntilObserver.h - Issue 210833004: Inform the client when the Service Worker rejects an install event

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/serviceworkers/WaitUntilObserver.h

Issue 210833004: Inform the client when the Service Worker rejects an install event (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h ('K') | « Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h ('k') | Source/modules/serviceworkers/WaitUntilObserver.cpp » ('j') | public/web/WebServiceWorkerContextClient.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WaitUntilObserver_h	5 #ifndef WaitUntilObserver_h

6 #define WaitUntilObserver_h	6 #define WaitUntilObserver_h

7	7

8 #include "core/dom/ContextLifecycleObserver.h"	8 #include "core/dom/ContextLifecycleObserver.h"

9 #include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"	9 #include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"

10 #include "wtf/Forward.h"	10 #include "wtf/Forward.h"

(...skipping 26 matching lines...) Expand all Loading...
37	37

38 WaitUntilObserver(ExecutionContext*, int eventID);	38 WaitUntilObserver(ExecutionContext*, int eventID);

39	39

40 void reportError(const ScriptValue&);	40 void reportError(const ScriptValue&);

41	41

42 void incrementPendingActivity();	42 void incrementPendingActivity();

43 void decrementPendingActivity();	43 void decrementPendingActivity();

44	44

45 int m_eventID;	45 int m_eventID;

46 int m_pendingActivity;	46 int m_pendingActivity;

	47 bool m_error;
	kinuko 2014/03/25 11:26:51 m_hasError might be better? (Otherwise this var na m_hasError might be better? (Otherwise this var name feels it records actual error code etc) falken 2014/03/26 07:26:36 Done, replaced with the new enum. Show quoted text On 2014/03/25 11:26:51, kinuko wrote: > m_hasError might be better? (Otherwise this var name feels it records actual > error code etc) Done, replaced with the new enum.
47 };	48 };

48	49

49 } // namespace WebCore	50 } // namespace WebCore

50	51

51 #endif // WaitUntilObserver_h	52 #endif // WaitUntilObserver_h

OLD	NEW