Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2108313002: Remove the Pver3 safe_browsing_test server (Closed)

Created:
4 years, 5 months ago by Nathan Parker
Modified:
4 years, 5 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Pver3 safe_browsing_test server and related bits. It is both broken and deprecated. It'll be sufficiently different for pver4 that we should start from scratch. BUG=612189, 86092 Committed: https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65 Cr-Commit-Position: refs/heads/master@{#403244}

Patch Set 1 #

Patch Set 2 : Update a few files I missed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -761 lines) Patch
M .gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/safe_browsing/local_safebrowsing_test_server.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/safe_browsing/local_safebrowsing_test_server.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/safe_browsing/safe_browsing_test.cc View 1 chunk +0 lines, -557 lines 0 comments Download
M chrome/browser_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/test/data/safe_browsing/safe_browsing_testserver.py View 1 chunk +0 lines, -41 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/safe_browsing/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/safe_browsing/README.chromium View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/safe_browsing/safe_browsing.gyp View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Nathan Parker
4 years, 5 months ago (2016-06-29 20:41:47 UTC) #3
vakh (use Gerrit instead)
lgtm
4 years, 5 months ago (2016-06-29 20:47:28 UTC) #4
vakh (use Gerrit instead)
On 2016/06/29 at 20:41:47, nparker wrote: > chrome/browser_tests.isolate is empty? Is that intentional? Can we ...
4 years, 5 months ago (2016-06-29 20:47:54 UTC) #5
Nathan Parker
Hmm, it's not empty for me or my view from codereview.chromium.org. I just removed one ...
4 years, 5 months ago (2016-06-29 20:53:30 UTC) #6
vakh (use Gerrit instead)
On 2016/06/29 at 20:53:30, nparker wrote: > Hmm, it's not empty for me or my ...
4 years, 5 months ago (2016-06-29 20:57:46 UTC) #7
vakh (use Gerrit instead)
lgtm
4 years, 5 months ago (2016-06-29 20:57:50 UTC) #8
Nathan Parker
benwells@: Please review extensions/BUILD.gn thakis@: Please review chrome/* and third_party/* Thanks!
4 years, 5 months ago (2016-06-29 21:48:43 UTC) #10
benwells
lgtm
4 years, 5 months ago (2016-06-29 22:17:35 UTC) #11
Nico
lgtm
4 years, 5 months ago (2016-06-30 17:26:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108313002/20001
4 years, 5 months ago (2016-06-30 18:38:30 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 19:21:05 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 19:21:21 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:23:04 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b9b95345eb1f8a788ac3992bdec7ebd8bdccef65
Cr-Commit-Position: refs/heads/master@{#403244}

Powered by Google App Engine
This is Rietveld 408576698