Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 21083003: Adapt test expectations for failing blink test. (Closed)

Created:
7 years, 4 months ago by Michael Achenbach
Modified:
7 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Adapt test expectations for blink test. Also after giving it more time, this test times out only on the V8 waterfall under windows. It has an existing expectation for Win Debug, which holds now for all Win. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15948

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M tools/blink_tests/TestExpectations View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 4 months ago (2013-07-30 07:53:07 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 4 months ago (2013-07-30 08:40:35 UTC) #2
Michael Achenbach
7 years, 4 months ago (2013-07-30 08:51:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15948 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698