Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2108283002: Disabled xinput2 until edge cases can be fixed. (Closed)

Created:
4 years, 5 months ago by Will Shackleton
Modified:
4 years, 5 months ago
Reviewers:
bokan, sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled xinput2 until edge cases can be fixed. Forces all input devices to use xinput1, the previous path, until all the kinks are worked out with the new xinput2 path. BUG=616308 Committed: https://crrev.com/f7e731e7822967ab2d22530ea8d8487cf623ae3b Cr-Commit-Position: refs/heads/master@{#402966}

Patch Set 1 #

Patch Set 2 : Changed xinput to xinput2 #

Total comments: 1

Patch Set 3 : Changed comment to TODO and removed if #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/events/devices/x11/device_data_manager_x11.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
bokan
https://codereview.chromium.org/2108283002/diff/20001/ui/events/devices/x11/device_data_manager_x11.cc File ui/events/devices/x11/device_data_manager_x11.cc (right): https://codereview.chromium.org/2108283002/diff/20001/ui/events/devices/x11/device_data_manager_x11.cc#newcode776 ui/events/devices/x11/device_data_manager_x11.cc:776: if (xinput2_disabled) { No need for the variable and ...
4 years, 5 months ago (2016-06-29 18:34:25 UTC) #3
Will Shackleton
On 2016/06/29 18:34:25, bokan wrote: > https://codereview.chromium.org/2108283002/diff/20001/ui/events/devices/x11/device_data_manager_x11.cc > File ui/events/devices/x11/device_data_manager_x11.cc (right): > > https://codereview.chromium.org/2108283002/diff/20001/ui/events/devices/x11/device_data_manager_x11.cc#newcode776 > ...
4 years, 5 months ago (2016-06-29 18:39:15 UTC) #4
bokan
I tried this out locally with touchpad/pointer and looks like its back to non-smooth scrolling ...
4 years, 5 months ago (2016-06-29 18:42:53 UTC) #5
bokan
Also, please use bug 616308 in the CL description.
4 years, 5 months ago (2016-06-29 18:48:53 UTC) #6
Will Shackleton
On 2016/06/29 18:48:53, bokan wrote: > Also, please use bug 616308 in the CL description. ...
4 years, 5 months ago (2016-06-29 18:52:31 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108283002/40001
4 years, 5 months ago (2016-06-29 21:06:36 UTC) #10
sadrul
lgtm I would remove 2nd and 3rd paragraphs from the CL description.
4 years, 5 months ago (2016-06-29 21:47:12 UTC) #11
bokan
Thanks Sadrul, I've updated the description and I'll try to get this committed tonight since ...
4 years, 5 months ago (2016-06-29 21:50:26 UTC) #13
Will Shackleton
On 2016/06/29 21:50:26, bokan wrote: > Thanks Sadrul, I've updated the description and I'll try ...
4 years, 5 months ago (2016-06-29 21:54:02 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 22:25:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108283002/40001
4 years, 5 months ago (2016-06-29 22:28:34 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 22:38:59 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 22:39:13 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:42:05 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f7e731e7822967ab2d22530ea8d8487cf623ae3b
Cr-Commit-Position: refs/heads/master@{#402966}

Powered by Google App Engine
This is Rietveld 408576698