Strictly disable instantiation of AllStatic class

Strictly disable instantiation of AllStatic class

Since the intention of using AllStatic class is to provide classes that
only contain static method functions without member variables so it
doesn't have to be instantiated at all.

However, current implementation only disables dynamic instantiation, and
it can be detected at runtime by reaching UNREACHABLE().  And it can
still have instances allocated inside stack.

This blocks all those cases by deleting default constructor of AllStatic
class to prevent undesirable usage of it.

BUG=
R=jochen@chromium.org

Committed: https://crrev.com/446232f16b85504410d48dfadfab95da939bad92
Cr-Commit-Position: refs/heads/master@{#37532}

[honggyu.kim, 2016-06-30 04:33:12]

Hi Jochen,

This may not be an important patch but I think it'd be better to make AllStatic
class more robust to prevent not intended usage.
Can you please review this patch?

Thanks,
Honggyu

[jochen (gone - plz use gerrit), 2016-06-30 15:16:11]

lgtm

[honggyu.kim, 2016-07-01 05:38:43]

On 2016/06/30 15:16:11, jochen wrote:
> lgtm

Thanks for the review!
As I mentioned I changed my email and updated in the previous patch below
https://codereview.chromium.org/2084163004/

Can you please have a look at it again?

Regards,
Honggyu

[honggyu.kim, 2016-07-04 07:43:27]

On 2016/07/01 05:38:43, honggyu.kim wrote:
> On 2016/06/30 15:16:11, jochen wrote:
> > lgtm

Hi Jochen,

Could you please commit this if you think it's fine?
Or should I press "Commit" button myself if I get LGTM from one of committers?
Sorry for bothering you but I'm just asking because I'm a newbie on this
project.

Thanks,
Honggyu

[honggyu.kim, 2016-07-05 13:28:36]

The CQ bit was checked by honggyu.kp@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 13:28:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 13:55:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 13:55:37]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-07-05 14:20:55]

On 2016/07/04 at 07:43:27, honggyu.kp wrote:
> On 2016/07/01 05:38:43, honggyu.kim wrote:
> > On 2016/06/30 15:16:11, jochen wrote:
> > > lgtm
> 
> Hi Jochen,
> 
> Could you please commit this if you think it's fine?
> Or should I press "Commit" button myself if I get LGTM from one of committers?
> Sorry for bothering you but I'm just asking because I'm a newbie on this
project.
> 
> Thanks,
> Honggyu

just press the button yourself

[honggyu.kim, 2016-07-05 14:22:18]

On 2016/07/05 14:20:55, jochen wrote:
> 
> just press the button yourself

Thanks, will do!

[honggyu.kim, 2016-07-05 14:22:26]

The CQ bit was checked by honggyu.kp@gmail.com

[commit-bot: I haz the power, 2016-07-05 14:22:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 14:24:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-05 14:27:43]

Description was changed from

==========
Strictly disable instantiation of AllStatic class

Since the intention of using AllStatic class is to provide classes that
only contain static method functions without member variables so it
doesn't have to be instantiated at all.

However, current implementation only disables dynamic instantiation, and
it can be detected at runtime by reaching UNREACHABLE().  And it can
still have instances allocated inside stack.

This blocks all those cases by deleting default constructor of AllStatic
class to prevent undesirable usage of it.

BUG=
R=jochen@chromium.org
==========

to

==========
Strictly disable instantiation of AllStatic class

Since the intention of using AllStatic class is to provide classes that
only contain static method functions without member variables so it
doesn't have to be instantiated at all.

However, current implementation only disables dynamic instantiation, and
it can be detected at runtime by reaching UNREACHABLE().  And it can
still have instances allocated inside stack.

This blocks all those cases by deleting default constructor of AllStatic
class to prevent undesirable usage of it.

BUG=
R=jochen@chromium.org

Committed: https://crrev.com/446232f16b85504410d48dfadfab95da939bad92
Cr-Commit-Position: refs/heads/master@{#37532}
==========

[commit-bot: I haz the power, 2016-07-05 14:27:44]

Patchset 2 (id:??) landed as
https://crrev.com/446232f16b85504410d48dfadfab95da939bad92
Cr-Commit-Position: refs/heads/master@{#37532}