Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2108223002: Moves handful of classes in ash/wm/maximize_mode to ash/common (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@maximize_mode_window_manager
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves handful of classes in ash/wm/maximize_mode to ash/common These classes now only depend upon ash/common. BUG=612629 TEST=covered by tests R=jamescook@chromium.org TBR=jamescook@chromium.org Committed: https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15 Cr-Commit-Position: refs/heads/master@{#402888}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge #

Patch Set 4 : remove extraneous #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1136 lines) Patch
M ash/ash.gyp View 2 chunks +6 lines, -6 lines 0 comments Download
A + ash/common/wm/maximize_mode/maximize_mode_window_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/maximize_mode/maximize_mode_window_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/maximize_mode/maximize_mode_window_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/common/wm/maximize_mode/workspace_backdrop_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/maximize_mode/workspace_backdrop_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 2 2 chunks +1 line, -1 line 0 comments Download
D ash/wm/maximize_mode/DEPS View 1 chunk +0 lines, -24 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.cc View 2 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/maximize_mode/maximize_mode_window_manager.h View 1 chunk +0 lines, -137 lines 0 comments Download
D ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +0 lines, -285 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/maximize_mode/maximize_mode_window_state.h View 1 chunk +0 lines, -88 lines 0 comments Download
D ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +0 lines, -326 lines 0 comments Download
D ash/wm/maximize_mode/workspace_backdrop_delegate.h View 1 chunk +0 lines, -73 lines 0 comments Download
D ash/wm/maximize_mode/workspace_backdrop_delegate.cc View 1 chunk +0 lines, -177 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
sky
This is a straight move, so TBR
4 years, 5 months ago (2016-06-29 18:18:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108223002/60001
4 years, 5 months ago (2016-06-29 18:19:35 UTC) #4
James Cook
lgtm
4 years, 5 months ago (2016-06-29 18:21:29 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-29 19:08:00 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 19:08:20 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 19:10:11 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15
Cr-Commit-Position: refs/heads/master@{#402888}

Powered by Google App Engine
This is Rietveld 408576698