Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2108203003: Stop hiding soft input from CompositorViewHolder (Closed)

Created:
4 years, 5 months ago by Changwan Ryu
Modified:
4 years, 5 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, yabinh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop hiding soft input from CompositorViewHolder CompositorViewHolder hides keyboard on switching tabs. We found that it is causing a StrictMode violation error in KK (due to a flaw in Android framework). But CVH removes ContentView, which eventually calls ImeAdapter#onViewFocusChanged(false) and then we hide the keyboard anyways. Therefore, removing the redundant code from CVH and adding a test to future-proof the behavior. BUG=623256 TBR=dtrainor@chromium.org Committed: https://crrev.com/c24619b26e3bed664e25482300d085ea8f1eaefe Cr-Commit-Position: refs/heads/master@{#403325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/compositor/overlays/strip/TabStripTest.java View 3 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Changwan Ryu
aelias@, could you take a look in IME's regard?
4 years, 5 months ago (2016-06-30 08:45:08 UTC) #2
aelias_OOO_until_Jul13
lgtm. Replacing OWNERS reviewer with dfalcantara@ since dtrainor@ is OOO.
4 years, 5 months ago (2016-06-30 19:22:13 UTC) #4
gone
OWNERs lgtm
4 years, 5 months ago (2016-06-30 20:08:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108203003/1
4 years, 5 months ago (2016-06-30 22:27:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 23:08:35 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 23:08:39 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:11:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c24619b26e3bed664e25482300d085ea8f1eaefe
Cr-Commit-Position: refs/heads/master@{#403325}

Powered by Google App Engine
This is Rietveld 408576698