Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2108193004: [Material][Mac] Fixed HTTP and HTTPS icons in dark mode (Closed)

Created:
4 years, 5 months ago by spqchan
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : removed extra icon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
spqchan
PTAL Looks like we missed a couple of icons since the CL to remove it ...
4 years, 5 months ago (2016-06-30 18:47:32 UTC) #3
spqchan
+avi for OWNERS
4 years, 5 months ago (2016-06-30 21:05:52 UTC) #5
Avi (use Gerrit)
lgtm
4 years, 5 months ago (2016-07-01 01:24:20 UTC) #6
Avi (use Gerrit)
On 2016/06/30 18:47:32, spqchan wrote: > PTAL > > Looks like we missed a couple ...
4 years, 5 months ago (2016-07-01 01:25:28 UTC) #7
spqchan
Awesome, thanks. I talked to them and they're okay with it
4 years, 5 months ago (2016-07-01 16:34:32 UTC) #8
spqchan
4 years, 5 months ago (2016-07-01 19:17:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d9bdbbd41f4e4d61d9f512100e9ed03ed122ed05 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698