[modules] AST and parser rework.

src/globals.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_GLOBALS_H_
 #define V8_GLOBALS_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 841 matching lines @@
 
 // The order of this enum has to be kept in sync with the predicates below.
 enum VariableMode {
   // User declared variables:
   VAR,  // declared via 'var', and 'function' declarations
 
   CONST_LEGACY,  // declared via legacy 'const' declarations
 
   LET,  // declared via 'let' declarations (first lexical)
 
+  // TODO(neis): Is it correct to make this one of the lexical modes?
+  IMPORT,  // declared via 'import' declarations (except namespace imports)
+
   CONST,  // declared via 'const' declarations (last lexical)
 
   // Variables introduced by the compiler:
   TEMPORARY,  // temporary variables (not user-visible), stack-allocated
               // unless the scope as a whole has forced context allocation
 
   DYNAMIC,  // always require dynamic lookup (we don't know
             // the declaration)
 
   DYNAMIC_GLOBAL,  // requires dynamic lookup, but we know that the
@@ skipping 14 matching lines @@
 inline bool IsDeclaredVariableMode(VariableMode mode) {
   return mode >= VAR && mode <= CONST;
 }
 
 
 inline bool IsLexicalVariableMode(VariableMode mode) {
   return mode >= LET && mode <= CONST;
 }
 
 
 inline bool IsImmutableVariableMode(VariableMode mode) {

[adamk, 2016/07/13 18:38:21]

I think you'll want to add IMPORT here too (or a TODO).

[neis, 2016/07/14 10:28:23]

Yeah, probably. Added it. I suspect there are many more places where we'll have
to account for the new mode.

   return mode == CONST || mode == CONST_LEGACY;
 }
 
 
 enum class VariableLocation {
   // Before and during variable allocation, a variable whose location is
   // not yet determined.  After allocation, a variable looked up as a
   // property on the global object (and possibly absent).  name() is the
   // variable name, index() is invalid.
   UNALLOCATED,
@@ skipping 212 matching lines @@
   return static_cast<uint32_t>(bit_cast<uintptr_t>(address) >>
                                kPointerSizeLog2);
 }
 
 }  // namespace internal
 }  // namespace v8
 
 namespace i = v8::internal;
 
 #endif  // V8_GLOBALS_H_