Change error handling.

Change error handling.

There is a new file rasta_errors.dart patching 'dart:core' with methods
that may be called by rasta->kernel to throw runtime errors.

R=ahe@google.com

Committed: https://github.com/dart-lang/rasta/commit/b8fc503e25eb5118ec7a757a21589f64cdad902c

[asgerf, 2016-06-29 15:21:40]

asgerf@google.com changed reviewers:
+ ahe@google.com, kustermann@google.com

[ahe, 2016-06-29 15:53:56]

lgtm

Nice!

https://codereview.chromium.org/2108193002/diff/1/dart_vm_standalone/rasta_er...
File dart_vm_standalone/rasta_errors.dart (right):

https://codereview.chromium.org/2108193002/diff/1/dart_vm_standalone/rasta_er...
dart_vm_standalone/rasta_errors.dart:1: library dart.core._rasta_errors;
Add copyright.

https://codereview.chromium.org/2108193002/diff/1/lib/unresolved.dart
File lib/unresolved.dart (right):

https://codereview.chromium.org/2108193002/diff/1/lib/unresolved.dart#newcode60
lib/unresolved.dart:60: 
Extra line.

https://codereview.chromium.org/2108193002/diff/1/lib/unresolved.dart#newcode74
lib/unresolved.dart:74: ir.Expression buildThrowNoSuchMethodError(ir.Procedure
exceptionBuilder,
For consistency, please have one formal parameter per line if the formal
parameters don't fit on one line.

Also, add newline after (.

[asgerf, 2016-06-30 08:47:33]

https://codereview.chromium.org/2108193002/diff/1/dart_vm_standalone/rasta_er...
File dart_vm_standalone/rasta_errors.dart (right):

https://codereview.chromium.org/2108193002/diff/1/dart_vm_standalone/rasta_er...
dart_vm_standalone/rasta_errors.dart:1: library dart.core._rasta_errors;
On 2016/06/29 15:53:56, ahe wrote:
> Add copyright.

Done.

https://codereview.chromium.org/2108193002/diff/1/lib/unresolved.dart
File lib/unresolved.dart (right):

https://codereview.chromium.org/2108193002/diff/1/lib/unresolved.dart#newcode60
lib/unresolved.dart:60: 
On 2016/06/29 15:53:56, ahe wrote:
> Extra line.

Done.

https://codereview.chromium.org/2108193002/diff/1/lib/unresolved.dart#newcode74
lib/unresolved.dart:74: ir.Expression buildThrowNoSuchMethodError(ir.Procedure
exceptionBuilder,
On 2016/06/29 15:53:56, ahe wrote:
> For consistency, please have one formal parameter per line if the formal
> parameters don't fit on one line.
> 
> Also, add newline after (.

Done, though I really think we should just stick to dartfmt.

[asgerf, 2016-06-30 08:51:33]

Description was changed from

==========
Change error handling.

There is a new file rasta_errors.dart patching 'dart:core' with methods
that may be called by rasta->kernel to throw runtime errors.
==========

to

==========
Change error handling.

There is a new file rasta_errors.dart patching 'dart:core' with methods
that may be called by rasta->kernel to throw runtime errors.

R=ahe@google.com

Committed:
https://github.com/dart-lang/rasta/commit/b8fc503e25eb5118ec7a757a21589f64cda...
==========

[asgerf, 2016-06-30 08:51:35]

Committed patchset #2 (id:20001) manually as
b8fc503e25eb5118ec7a757a21589f64cdad902c (presubmit successful).