Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2108153002: Do not wait for first video frame to start playing audio in a MediaStream. (Closed)

Created:
4 years, 5 months ago by Guido Urdaneta
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not wait for first video frame to start playing audio in a MediaStream. BUG=403710 Committed: https://crrev.com/7161bf0bd58551daac1aa486ca9bb13376efbbec Cr-Commit-Position: refs/heads/master@{#402845}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/test/data/media/getusermedia.html View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Guido Urdaneta
Hi, PTAL
4 years, 5 months ago (2016-06-29 10:49:54 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 5 months ago (2016-06-29 10:56:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108153002/20001
4 years, 5 months ago (2016-06-29 17:11:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 17:16:58 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:17:12 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7161bf0bd58551daac1aa486ca9bb13376efbbec Cr-Commit-Position: refs/heads/master@{#402845}
4 years, 5 months ago (2016-06-29 17:19:20 UTC) #10
Guido Urdaneta
4 years, 5 months ago (2016-07-07 11:24:51 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2124013003/ by guidou@chromium.org.

The reason for reverting is: According to the spec, we should switch state to
HAVE_METADATA only after we know the dimensions of the video.
See crbug.com/625943.

Powered by Google App Engine
This is Rietveld 408576698