Issue 210813004: Fix approximation of CanDeoptimize() and other small store elimination fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210813004: Fix approximation of CanDeoptimize() and other small store elimination fixes. (Closed)

Created:
6 years, 9 months ago by titzer

Modified:
6 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix approximation of CanDeoptimize() and other small store elimination fixes. R=svenpanne@chromium.org BUG=

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	src/hydrogen-instructions.cc	View		3 chunks	+1 line, -2 lines	0 comments	Download
	M	src/hydrogen-store-elimination.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

Extended version of this CL with a dynamic check that CanDeoptimize doesn't lie: https://codereview.chromium.org/222263002/. No ...

6 years, 8 months ago (2014-04-02 15:12:28 UTC) #2

Sven Panne

6 years, 8 months ago (2014-04-03 10:39:54 UTC) #3

On 2014/04/02 15:12:28, Sven Panne wrote:
> Extended version of this CL with a dynamic check that CanDeoptimize doesn't
lie:
> https://codereview.chromium.org/222263002/. No tricky stuff for a better
> approximation there yet, but at least it survives our test suite.

Closing this issue, superseded by the one mentioned above...

Expand Messages | Collapse Messages