Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 210813003: Rename :ancestor to :host-context. (Closed)

Created:
6 years, 9 months ago by tasak
Modified:
6 years, 9 months ago
Reviewers:
dglazkov, rune
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Rename :ancestor to :host-context. The :host-context() functional pseudo-class tests whether there is an ancestor, outside the shadow tree, which matches a particular selector. Its syntax is: :host-context( <compound-selector> ) Spec link: http://drafts.csswg.org/css-scoping/#host-selector BUG=354287 TEST=no new tests because just renaming. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170016

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -529 lines) Patch
D LayoutTests/fast/dom/shadow/ancestor-first-child.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/dom/shadow/ancestor-first-child-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/ancestor-pseudo-class.html View 1 chunk +0 lines, -336 lines 0 comments Download
D LayoutTests/fast/dom/shadow/ancestor-pseudo-class-expected.txt View 1 chunk +0 lines, -47 lines 0 comments Download
M LayoutTests/fast/dom/shadow/host-pseudo-class.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/host-pseudo-class-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/hostcontext-first-child.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/hostcontext-first-child-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/hostcontext-pseudo-class.html View 22 chunks +44 lines, -44 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/hostcontext-pseudo-class-expected.txt View 1 chunk +15 lines, -15 lines 0 comments Download
M LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep.html View 1 2 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/CSSGrammar.y View 1 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/CSSParserValues.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/CSSTokenizer-in.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
tasak
6 years, 9 months ago (2014-03-25 09:45:55 UTC) #1
rune
non-OWNER lgtm
6 years, 9 months ago (2014-03-25 10:13:11 UTC) #2
dglazkov
lgtm
6 years, 9 months ago (2014-03-25 15:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/210813003/1
6 years, 9 months ago (2014-03-25 15:54:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 15:57:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-25 15:57:48 UTC) #6
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-26 01:56:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/210813003/1
6 years, 9 months ago (2014-03-26 01:56:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 01:56:59 UTC) #9
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-26 01:56:59 UTC) #10
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-26 03:53:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/210813003/110001
6 years, 9 months ago (2014-03-26 03:53:43 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 03:54:01 UTC) #13
commit-bot: I haz the power
Failed to apply patch for Source/core/css/CSSSelector.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-26 03:54:01 UTC) #14
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-26 03:58:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/210813003/230001
6 years, 9 months ago (2014-03-26 03:58:39 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 05:04:41 UTC) #17
Message was sent while issue was closed.
Change committed as 170016

Powered by Google App Engine
This is Rietveld 408576698