Issue 210813002: Rename /shadow-deep/ combinator to /deep/

Issue 210813002: Rename /shadow-deep/ combinator to /deep/ (Closed)

Created:
6 years, 9 months ago by tasak

Modified:
6 years, 9 months ago

Reviewers:
dglazkov, rune

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename /shadow-deep/ combinator to /deep/ Shadow DOM styling spec link: http://drafts.csswg.org/css-scoping/#deep-combinator BUG=348891 TEST=no new tests because just renaming. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169960

Patch Set 1 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -125 lines)			Patch
M	LayoutTests/fast/css/invalidation/detach-reattach-shadow.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat.html	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/dynamically-added-cat-hat-rules.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/querySelector-for-multiple-shadowroots.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/querySelector-for-multiple-shadowroots-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/querySelector-for-useragent-shadowroot.html	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/querySelector-for-useragent-shadowroot-expected.txt	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep.html	View	2 chunks	+19 lines, -19 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt	View	3 chunks	+19 lines, -19 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/scrollbar.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-and-list-elements.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-to-younger.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadowdom-reprojection-1.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadowdom-reprojection-2.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/style-with-cat.html	View	22 chunks	+38 lines, -38 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/style-with-cat-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSGrammar.y	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSSelector.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rune

LGTM with nit: You should get rid of the "cat" and "hat" references from the ...

6 years, 9 months ago (2014-03-25 10:33:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/210813002/40001

6 years, 9 months ago (2014-03-25 15:55:39 UTC) #4

Message was sent while issue was closed.

Change committed as 169960

Expand Messages | Collapse Messages